Develop#38
Merged
albertomandlate merged 6 commits intorelease-v0.8.5from May 22, 2025
Merged
Conversation
Mudou a propriedade `Indent` de `true` para `false` na configuração do `XmlWriterSettings`. Isso resulta em uma saída XML mais compacta, sem indentação.
Alterar configuração de indentação do XML
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands CodeQL analysis coverage to the develop and release-** branches with localized step names in Portuguese, and tweaks the Mozambique SAF-T generator for performance by disabling XML indentation.
- Add
developandrelease-**branches to CodeQL triggers and translate workflow step names to Portuguese. - Change
XmlWriterSettings.IndenttofalseinMozambiqueSaftGeneratorto improve performance.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs | Disable XML indentation (Indent = false) for potential performance gains. |
| .github/workflows/codeql.yml | Include develop and release-** branches and translate step names to Portuguese. |
Comments suppressed due to low confidence (2)
.github/workflows/codeql.yml:24
- [nitpick] The workflow step names mix imperative and gerund forms (e.g., 'Analisar' vs. 'Fazendo analises com o CodeQL'). Consider using a consistent verb form, such as all infinitive commands or all gerunds, for better readability and consistency.
- name: Analisar (${{ matrix.language }})
src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261
- [nitpick] Consider adding a comment explaining why indentation is disabled and any potential trade-offs (e.g., reduced readability vs. performance improvement).
Indent = false,
Contributor
Author
|
This pull request includes updates to the CodeQL workflow configuration and a minor code adjustment in the Mozambique SAF-T generator. The most important changes include expanding branch coverage for CodeQL workflows, localizing workflow step names to Portuguese, and modifying XML writer settings to disable indentation. Updates to CodeQL Workflow:
Changes in Mozambique SAF-T Generator:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the CodeQL workflow configuration and a minor adjustment in the Mozambique SAF-T generator. The most important changes involve expanding branch coverage for CodeQL analysis, translating workflow step names to Portuguese, and modifying XML writer settings for performance.
Updates to CodeQL workflow configuration:
.github/workflows/codeql.yml: Expanded branch coverage for triggering CodeQL analysis to includedevelopandrelease-**branches..github/workflows/codeql.yml: Translated workflow step names to Portuguese, including "Analyze" to "Analisar," "Initialize CodeQL" to "Inicializar o CodeQL," and "Perform CodeQL Analysis" to "Fazendo analises com o CodeQL." [1] [2] [3]Adjustment in Mozambique SAF-T generator:
src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs: ChangedXmlWriterSettings.Indentfromtruetofalseto potentially improve performance by disabling XML indentation.